lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Mar 2010 15:35:33 -0700 (PDT) From: David Miller <davem@...emloft.net> To: andreas.fenkart@...eamunlimited.com CC: netdev@...r.kernel.org Subject: Re: [1/1] ARC vmac ethernet driver. This needs some changes. First, you'll need to add some proper dependencies to the Kconfig for this driver before we can apply it. At a minimum you have to depend upon HAS_DMA otherwise the dma_*() interface calls won't link on platforms such as s390. Also: +static char *mac_addr; +module_param(mac_addr, charp, 0644); +MODULE_PARM_DESC(mac_addr, "MAC address as colon separated hexadecimals"); Please remove this, we have interfaces for setting the ethernet address. If the device address can't be probed, use a random ethernet address as a default (by using linux/etherdevice.h's random_ether_addr()) If the user wants to override they can do so with the 'ifconfig' command. This is how we consistently handle this situation in every ethernet driver, so please don't try to make arguments as to why your driver should handle this differently. Thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists