netdev - Re: [PATCH net-next-2.6 v6 08/12] net-caif: add CAIF socket implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1268690031.2700.9.camel@localhost.localdomain>
Date:	Mon, 15 Mar 2010 14:53:51 -0700
From:	Marcel Holtmann <marcel@...tmann.org>
To:	sjur.brandeland@...ricsson.com
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	daniel.martensson@...ricsson.com, kaber@...sh.net,
	stefano.babic@...ic.homelinux.org, randy.dunlap@...cle.com
Subject: Re: [PATCH net-next-2.6 v6 08/12] net-caif: add CAIF socket
 implementation

Hi Sjur,

> +	/*
> +	 * The sock->type specifies the socket type to use. The CAIF socket is
> +	 * a packet stream in the sence that it is packet based.
> +	 * CAIF trusts the reliability of the link, no resending is implemented.
> +	 */
> +	if (sock->type != SOCK_SEQPACKET)
> +		return -ESOCKTNOSUPPORT;

we came to an interesting detail here when testing with a STE modem. Why
is this SEQPACKET and not a STREAM. Especially with the AT command
channels it is kinda weird that you have an MTU. The AT specification
doesn't really have any defined behavior when using a sequential packet
transport. It is more a stream based socket.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html