netdev - RE: [PATCH net-next-2.6 v6 08/12] net-caif: add CAIF socket implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Mar 2010 14:27:21 +0100
From:	Sjur Brændeland <sjur.brandeland@...ricsson.com>
To:	"Marcel Holtmann" <marcel@...tmann.org>
Cc:	<netdev@...r.kernel.org>, <davem@...emloft.net>,
	"Daniel Martensson" <daniel.martensson@...ricsson.com>,
	<kaber@...sh.net>, <stefano.babic@...ic.homelinux.org>,
	<randy.dunlap@...cle.com>
Subject: RE: [PATCH net-next-2.6 v6 08/12] net-caif: add CAIF socket implementation

Hi Marcel.

Marcel Holtmann wrote:
>> +	/*
>> +	 * The sock->type specifies the socket type to use. The CAIF
>> socket is +	 * a packet stream in the sence that it is packet based.
>> +	 * CAIF trusts the reliability of the link, no resending is
>> implemented. +	 */ +	if (sock->type != SOCK_SEQPACKET)
>> +		return -ESOCKTNOSUPPORT;
> 
> we came to an interesting detail here when testing with a STE modem.
> Why is this SEQPACKET and not a STREAM.

The reason is that CAIF provides different services not just AT,
and some of them are really packet oriented such as Utility links and
Video. It would not be right to provide a stream based solution in this case.

> Especially with the AT
> command channels it is kinda weird that you have an MTU. The AT
> specification doesn't really have any defined behavior when using a
> sequential packet transport. It is more a stream based socket.

Yes I see your point. In order to limit the effort and simplify
caif_socket we ended up implementing only SEQPACKET. 

BR/Sjur
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html