netdev - Re: [PATCH RFC] tun: add ioctl to modify vnet header size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100317221117.GA7541@redhat.com>
Date:	Thu, 18 Mar 2010 00:11:17 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	David Stevens <dlstevens@...ibm.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	David Woodhouse <David.Woodhouse@...el.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	netdev-owner@...r.kernel.org, Paul Moore <paul.moore@...com>,
	sri@...ux.vnet.ibm.com
Subject: Re: [PATCH RFC] tun: add ioctl to modify vnet header size

On Wed, Mar 17, 2010 at 03:02:44PM -0700, David Stevens wrote:
> netdev-owner@...r.kernel.org wrote on 03/17/2010 02:35:04 PM:
> 
> > On Wed, Mar 17, 2010 at 02:10:11PM -0700, David Stevens wrote:
> > > Shouldn't we enforce a maximum too? Esp. if overflow/underflow
> > > will break any of the checks when it's used.
> > > 
> > >                                 +-DLS
> > 
> > So the maximum is MAX_INT :)
> > I don't think it can break any checks that aren't
> > already broken - what do you have in mind?
> 
>         I was thinking more like a page. At least, it'd be better
> to fail when trying to set it large than failing allocations
> later. As a header, it really ought to be small.
>         But if it works, or fails gracefully, at 2^31-1 on 32-bit
> machines, negative values, etc, then it's ok. Just a suggestion.
> 
>                                                         +-DLS

All this does is set how much of the buffer to skip, this option does
not allocate any memory.  So if you set it to a value > length that you
passed in, you get -EINVAL. Anything else should work.  Negative values
are checked for and return -EINVAL when you try to set it.  At least,
all that's by design - pls take a look at the code and if you see any
issues, speak up please.

I agree we don't really need to support very large values here,
it just seemed less work.

-- 
MST
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html