netdev - Re: [PATCH] pktgen node allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1268990933.3048.15.camel@edumazet-laptop>
Date:	Fri, 19 Mar 2010 10:28:53 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Robert Olsson <robert@...julf.net>
Cc:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] pktgen node allocation

Le vendredi 19 mars 2010 à 09:44 +0100, Robert Olsson a écrit :
> 
> Hi,
> Here is patch to manipulate packet node allocation and implicitly 
> how packets are DMA'd etc.
> 
> The flag NODE_ALLOC enables the function and numa_node_id();
> when enabled it can also be explicitly controlled via a new 
> node parameter
> 
> Tested this with 10 Intel 82599 ports w. TYAN S7025 E5520 CPU's.
> Was able to TX/DMA ~80 Gbit/s to Ethernet wires.
> 
> Cheers
> 					--ro
> 

I cannot understand how this can help.

__netdev_alloc_skb() is supposed to already take into account NUMA
properties :

int node = dev->dev.parent ? dev_to_node(dev->dev.parent) : -1;

If this doesnt work, we should correct core stack, not only pktgen :)

Are you allocating memory in the node where pktgen CPU is running or the
node close to the NIC ?


Thanks


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html