netdev - Re: [net-next-2.6 PATCH] ipoib: remove addrlen check for mc addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100322.183450.135981771.davem@davemloft.net>
Date:	Mon, 22 Mar 2010 18:34:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jpirko@...hat.com
Cc:	jgunthorpe@...idianresearch.com, netdev@...r.kernel.org,
	ogerlitz@...taire.com, linux-rdma@...r.kernel.org,
	monis@...taire.com
Subject: Re: [net-next-2.6 PATCH] ipoib: remove addrlen check for mc
 addresses

From: Jiri Pirko <jpirko@...hat.com>
Date: Mon, 22 Mar 2010 18:26:14 +0100

> Mon, Mar 22, 2010 at 05:59:16PM CET, jgunthorpe@...idianresearch.com wrote:
>>On Mon, Mar 22, 2010 at 02:21:39PM +0100, Jiri Pirko wrote:
>>> Finally this bit can be removed. Currently, after the bonding driver is
>>> changed/fixed (32a806c194ea112cfab00f558482dd97bee5e44e net-next-2.6),
>>> that's not possible for an addr with different length than dev->addr_len
>>> to be present in list. Removing this check as in new mc_list there will be
>>> no addrlen in the record.
>>
>>Maybe just make this check a WARN_ON?
> 
> As I said, addrlen will no longer be in record (because it would have no
> meaning since length ot the addr is always dev->addr_len)
> 
>>Can userspace create a mc_list
>>entry with the wrong size via netlink?
> 
> Nope - this is not possible. dev->addr_len is used.

I've applied your patch, thanks Jiri.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html