netdev - Re: [PATCH] r8169: Fix rtl8169_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100325113038.GA3471@swordfish.minsk.epam.com>
Date:	Thu, 25 Mar 2010 13:30:38 +0200
From:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Oleg Nesterov <oleg@...hat.com>,
	David Miller <davem@...emloft.net>,
	Francois Romieu <romieu@...zoreil.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] r8169: Fix rtl8169_rx_interrupt()

Hello,

On (03/16/10 19:48), Eric Dumazet wrote:
[..]
> OK thanks for the report, this rtl8169_reset_task() seems pretty buggy,
> or multiple invocation...
> 
> Did you tried removing the rtl8169_schedule_work() call from
> rtl8169_rx_interrupt() ?
> 
> Maybe the reset is not necessary at all in case of fifo overflow..
> 
> Cumulative patch :
> 
[..]

Eric, I think you can put Tested-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
on the cumulative patch as I don't see any errors with pktgen over LAN testing.

Thanks.


	Sergey
Content of type "application/pgp-signature" skipped