[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6522.1269517044@redhat.com>
Date: Thu, 25 Mar 2010 11:37:24 +0000
From: David Howells <dhowells@...hat.com>
To: Eric Dumazet <eric.dumazet@...il.com>
Cc: dhowells@...hat.com, paul.moore@...com, netdev@...r.kernel.org
Subject: Re: [PATCH] NETLABEL: Fix an RCU warning
Eric Dumazet <eric.dumazet@...il.com> wrote:
> Sorry this is not the right fix.
>
> Fix is to change the dereference check to take into account the lock
> owned here.
Then the comments on netlbl_unlhsh_hash(), netlbl_unlhsh_search_iface(),
netlbl_unlhsh_search_iface_def() and netlbl_unlhsh_add_iface() are all wrong,
for all of them say:
* The caller is responsible for calling the rcu_read_[un]lock()
* functions.
Furthermore, netlabel_unlhsh_add() and netlabel_unlhsh_remove() _do_ wrap the
calls to those functions in rcu_read_lock'd sections.
David
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists