lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Mar 2010 08:30:45 -0400 From: Stephen Clark <sclark46@...thlink.net> To: Ben Hutchings <bhutchings@...arflare.com> CC: Marcel Holtmann <marcel@...tmann.org>, Elina Pasheva <epasheva@...rrawireless.com>, David Brownell <dbrownell@...rs.sourceforge.net>, Rory Filer <rfiler@...rrawireless.com>, netdev@...r.kernel.org, linux-usb <linux-usb@...r.kernel.org> Subject: Re: [ANNOUNCEMENT] NET: usb: sierra_net.c driver On 03/28/2010 08:44 PM, Ben Hutchings wrote: > On Sun, 2010-03-28 at 15:12 -0400, Stephen Clark wrote: >> On 03/28/2010 11:57 AM, Marcel Holtmann wrote: >>> Hi Elina, >>> >>>> +static const struct driver_info sierra_net_info_68A3 = { >>>> + .description = "Sierra Wireless USB-Ethernet Modem", >>>> + .flags = FLAG_ETHER | FLAG_SEND_ZLP, >>>> + .bind = sierra_net_bind, >>>> + .unbind = sierra_net_unbind, >>>> + .status = sierra_net_status, >>>> + .rx_fixup = sierra_net_rx_fixup, >>>> + .tx_fixup = sierra_net_tx_fixup, >>>> + .data = (unsigned long)&sierra_net_info_data_68A3, >>>> +}; >>> >>> the FLAG_ETHER is wrong here. Please use FLAG_WWAN to clearly mark these >>> interfaces. >>> >>> Otherwise we have wrong DEVTYPE uevent assignments and userspace will >>> treat them as real Ethernet cards. And that should not happen. As a nice >> Why shouldn't that happen if they look like NIC cards? > [...] > > This information is important for management interfaces. The user > doesn't care what your device looks like at the kernel level - they know > it's a wireless broadband device and they expect to see a device > labelled as such in Network Manager or whatever they use. > > Ben. > You sound like a windows guy! Whats with everything having to use NetworkManager!? Are people so dumb they can't figure things out from the command line. If it acts like a NIC it should be a NIC. I am so tired of eveyone trying to make Linux look and act like WINBLOWS. -- "They that give up essential liberty to obtain temporary safety, deserve neither liberty nor safety." (Ben Franklin) "The course of history shows that as a government grows, liberty decreases." (Thomas Jefferson) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists