netdev - Re: [PATCH net-next-2.6 v8 00/12] net-caif: introducing CAIF protocol stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Mar 2010 01:05:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sjur.brandeland@...ricsson.com
Cc:	netdev@...r.kernel.org, marcel@...tmann.org,
	daniel.martensson@...ricsson.com, sjurbr@...il.com
Subject: Re: [PATCH net-next-2.6 v8 00/12] net-caif: introducing CAIF
 protocol stack


You're directly accessing SKB data members instead of using
the portable interfaces defined in linux/skbuff.h, therefore
the build fails on 64-bit.

How many revisions of this patch set and not once has it been even
build tested on 64-bit?

net/caif/cfpkt_skbuff.c: In function ‘cfpkt_peek_head’:
net/caif/cfpkt_skbuff.c:121: error: invalid operands to binary - (have ‘sk_buff_data_t’ and ‘unsigned char *’)
net/caif/cfpkt_skbuff.c: In function ‘cfpkt_append’:
net/caif/cfpkt_skbuff.c:336: error: invalid operands to binary - (have ‘sk_buff_data_t’ and ‘unsigned char *’)
net/caif/cfpkt_skbuff.c:352: error: invalid operands to binary - (have ‘sk_buff_data_t’ and ‘unsigned char *’)
net/caif/cfpkt_skbuff.c:358: warning: assignment makes integer from pointer without a cast
net/caif/cfpkt_skbuff.c:364: error: invalid operands to binary - (have ‘sk_buff_data_t’ and ‘unsigned char *’)
net/caif/cfpkt_skbuff.c:364: warning: passing argument 1 of ‘__builtin_memcpy’ makes pointer from integer without a cast
net/caif/cfpkt_skbuff.c:364: note: expected ‘void *’ but argument is of type ‘sk_buff_data_t’
net/caif/cfpkt_skbuff.c: In function ‘cfpkt_split’:
net/caif/cfpkt_skbuff.c:377: error: invalid operands to binary - (have ‘sk_buff_data_t’ and ‘u8 *’)
net/caif/cfpkt_skbuff.c:382: warning: comparison between pointer and integer
net/caif/cfpkt_skbuff.c:397: warning: assignment makes integer from pointer without a cast
net/caif/cfpkt_skbuff.c: In function ‘cfpkt_log_pkt’:
net/caif/cfpkt_skbuff.c:425: error: invalid operands to binary - (have ‘sk_buff_data_t’ and ‘unsigned char *’)
net/caif/cfpkt_skbuff.c:427: error: invalid operands to binary - (have ‘sk_buff_data_t’ and ‘unsigned char *’)
net/caif/cfpkt_skbuff.c:430: error: invalid operands to binary - (have ‘sk_buff_data_t’ and ‘unsigned char *’)