netdev - Re: Undefined behaviour of connect(fd, NULL, 0);

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100401072412.032aa8e6@notabene.brown>
Date:	Thu, 1 Apr 2010 07:24:12 +1100
From:	Neil Brown <neilb@...e.de>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	netdev@...r.kernel.org
Subject: Re: Undefined behaviour of connect(fd, NULL, 0);

On Wed, 31 Mar 2010 11:49:36 -0700
Stephen Hemminger <shemminger@...tta.com> wrote:

> On Wed, 31 Mar 2010 22:36:37 +1100
> Neil Brown <neilb@...e.de> wrote:
> 
> > 
> > Hi Netdev.
> > 
> > We have a customer who was reporting strangely unpredictable behaviour of an
> > in-house application that used networking.
> > 
> > It called connect on a non-blocking socket and subsequently called
> >    connect(fd, NULL, 0)
> > 
> > to check if the connection had succeeded.
> > This would sometime "work" and sometimes close the connection.
> > 
> > Looking at the code (sys_connect, move_addr_to_kernel, inet_stream_connect),
> > it seems that in this case an uninitialised on-stack address is passed
> > to inet_stream_connect and it makes a decision based on ->sa_family (which is
> > uninitialised).
> > 
> > It seems clear that connect(fd, NULL, 0) is the wrong thing to do in this
> > circumstance, but I think it would be good if it failed consistently rather
> > than unpredictably.
> > 
> > Would it be appropriate for move_addr_to_kernel to zero out the remainder of
> > the address?
> >    memset(kaddr+ulen, 0, MAX_SOCK_ADDR-ulen);
> > ??
> > 
> > Then connect(fd, NULL, 0) would always break the connection.
> 
> I think the problem is inet_stream_connect referencing past addr_len.
> 
> --- a/net/ipv4/af_inet.c	2010-03-31 11:47:01.952910248 -0700
> +++ b/net/ipv4/af_inet.c	2010-03-31 11:48:09.852938406 -0700
> @@ -575,7 +575,7 @@ int inet_stream_connect(struct socket *s
>  
>  	lock_sock(sk);
>  
> -	if (uaddr->sa_family == AF_UNSPEC) {
> +	if (addr_len < sizeof(sa_family_t) || uaddr->sa_family == AF_UNSPEC) {
>  		err = sk->sk_prot->disconnect(sk, flags);
>  		sock->state = err ? SS_DISCONNECTING : SS_UNCONNECTED;
>  		goto out;

Thanks for the reply.

The implication of this patch is that
   connect(fd, NULL, 0)
is actually a valid way to check if an in-progress connection has completed.

Is that the intention?

Does all other address manipulation code check the addr_len ?? (probably).

Thanks,
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html