lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100331075746.GO2241@pengutronix.de> Date: Wed, 31 Mar 2010 09:57:46 +0200 From: Sascha Hauer <s.hauer@...gutronix.de> To: Bryan Wu <bryan.wu@...onical.com> Cc: gerg@...inux.org, amit.kucheria@...onical.com, kernel-team@...ts.ubuntu.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, w.sang@...gutronix.de Subject: Re: [PATCH] netdev/fec.c: add phylib supporting to enable carrier detection On Fri, Mar 26, 2010 at 05:50:52PM +0800, Bryan Wu wrote: > BugLink: http://bugs.launchpad.net/bugs/457878 > > - removed old MII phy control code > - add phylib supporting > - add ethtool interface to make user space NetworkManager works > > Tested on Freescale i.MX51 Babbage board. > > This patch is based on a patch from Frederic Rodo <fred.rodo@...il.com> > Hi Bryan, The MII speed is calculated twice with this patch applied, one time in fec_enet_mii_init and one time in fec_enet_init. The patch didn't work for me because the calculation is wrong (which of course is not your fault, it was wrong before). According to the Datasheet the MII clock is clk_get_rate() / (MII * 2). When we want to have a clock of 2.5MHz we have to do: clk_get_rate() / 5000000 With rounding this would be: (clk_get_rate() + 4999999) / 5000000 So you might want to add the following to your patch: fep->phy_speed = ((clk_get_rate(fep->clk) + 4999999) / 5000000) << 1; Otherwise the patch looks good to me. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists