netdev - Re: [PATCH 2/2] benet: fix the misusage of zero dma address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100405173724G.fujita.tomonori@lab.ntt.co.jp>
Date:	Mon, 5 Apr 2010 17:38:40 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	sathyap@...verengines.com
Cc:	fujita.tomonori@....ntt.co.jp, subbus@...verengines.com,
	sarveshwarb@...verengines.com, ajitk@...verengines.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] benet: fix the misusage of zero dma address

On Mon, 5 Apr 2010 13:52:02 +0530
Sathya Perla <sathyap@...verengines.com> wrote:

> On 05/04/10 16:40 +0900, FUJITA Tomonori wrote:
> > > > +		wrb->frag_len = 0;
> > > Why does wrb->frag_len need to be reset here?
> > > In the TX path, it is set to the proper value for data wrbs and zero
> > > for dummy and hdr wrbs.
> > 
> > I guess that I misunderstood why unmap_tx_frag() checks a dma address.
> > The checking is necessary to avoid calling pci_unamp_* API for dummy
> > hdr wrbs?
> Yes.
> > 
> > Anyway, if wrb->frag_len doesn't need to be reset here, the following
> > patch is ok?
> Yes. Thanks.
> 
> Acked-by: Sathya Perla <sathyap@...verengines.com>

Thanks!

Can I also get your ack on "[PATCH 1/2] benet: use the dma state API
instead of the pci equivalents"?

http://patchwork.ozlabs.org/patch/49265/


The reason why I want to replace the PCI DMA state API is:

http://marc.info/?l=linux-netdev&m=127037540020276&w=2

Note that I use DEFINE_DMA_UNMAP_ADDR for bus in struct
be_rx_page_info because dma_unmap_addr and DEFINE_DMA_UNMAP_ADDR are
supposed to be used together.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html