netdev - Re: [RFC PATCH 1/2] netdev: buffer infrastructure to log network driver's information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1270456946.1971.27.camel@edumazet-laptop>
Date:	Mon, 05 Apr 2010 10:42:26 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Koki Sanagi <sanagi.koki@...fujitsu.com>
Cc:	netdev@...r.kernel.org, izumi.taku@...fujitsu.com,
	kaneshige.kenji@...fujitsu.com, davem@...emloft.net,
	nhorman@...driver.com, jeffrey.t.kirsher@...el.com,
	jesse.brandeburg@...el.com, bruce.w.allan@...el.com,
	alexander.h.duyck@...el.com, peter.p.waskiewicz.jr@...el.com,
	john.ronciak@...el.com
Subject: Re: [RFC PATCH 1/2] netdev: buffer infrastructure to log network
 driver's information

Le lundi 05 avril 2010 à 15:52 +0900, Koki Sanagi a écrit :
> This patch implements buffer infrastructure under driver/net.
> This buffer records information from network driver.
> 
> Signed-off-by: Koki Sanagi <sanagi.koki@...fujitsu.com>
> ---
>   drivers/net/Kconfig     |    8 +
>   drivers/net/Makefile    |    1 +
>   drivers/net/ndrvbuf.c   |  535 +++++++++++++++++++++++++++++++++++++++++++++++
>   include/linux/ndrvbuf.h |   57 +++++
>   4 files changed, 601 insertions(+), 0 deletions(-)
> 

Wow, 600 lines... thats what I call bloat...

Why no use a very simple interface (printk like) ?

xxx_printf(dev->trace, "xmit qidx=%u ntu=%d->%d\n",
	   tx_ring->queue_index, first, tx_ring->next_to_use);

Anyway, this has nothing to do with network drivers and should be
discussed on lkml.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html