lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <C7F60C62.2AC93%scofeldm@cisco.com> Date: Thu, 22 Apr 2010 14:23:30 -0700 From: Scott Feldman <scofeldm@...co.com> To: David Miller <davem@...emloft.net> CC: <netdev@...r.kernel.org>, <chrisw@...hat.com> Subject: Re: [net-next PATCH 1/2] add iovnl netlink support On 4/21/10 11:48 PM, "David Miller" <davem@...emloft.net> wrote: > From: Scott Feldman <scofeldm@...co.com> > Date: Mon, 19 Apr 2010 12:18:07 -0700 > >> +#define IOVNL_PROTO_VERSION 1 >> + > > Please delete this in the final version, the macro isn't even used by > the code. > > We don't do protocol versioning in netlink. Instead we get the base > stuff solid from the beginning, and then if something needs fixing up > we handle this using new attributes in a way which is both backward > and forward compatible. Sounds good to me, was a cut-and-paste from dcbnl.h. How about: diff --git a/include/linux/dcbnl.h b/include/linux/dcbnl.h index b7cdbb4..8723491 100644 --- a/include/linux/dcbnl.h +++ b/include/linux/dcbnl.h @@ -22,8 +22,6 @@ #include <linux/types.h> -#define DCB_PROTO_VERSION 1 - struct dcbmsg { __u8 dcb_family; __u8 cmd; -scott -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists