[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20100422.160432.172292134.davem@davemloft.net>
Date: Thu, 22 Apr 2010 16:04:32 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: scofeldm@...co.com
Cc: netdev@...r.kernel.org, chrisw@...hat.com
Subject: Re: [net-next PATCH 1/2] add iovnl netlink support
From: Scott Feldman <scofeldm@...co.com>
Date: Thu, 22 Apr 2010 14:23:30 -0700
> On 4/21/10 11:48 PM, "David Miller" <davem@...emloft.net> wrote:
>
>> From: Scott Feldman <scofeldm@...co.com>
>> Date: Mon, 19 Apr 2010 12:18:07 -0700
>>
>>> +#define IOVNL_PROTO_VERSION 1
>>> +
>>
>> Please delete this in the final version, the macro isn't even used by
>> the code.
>>
>> We don't do protocol versioning in netlink. Instead we get the base
>> stuff solid from the beginning, and then if something needs fixing up
>> we handle this using new attributes in a way which is both backward
>> and forward compatible.
>
> Sounds good to me, was a cut-and-paste from dcbnl.h. How about:
This is perfectly fine except it got whitespace damanged by your
email client and needs a proper commit message and signoff :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists