netdev - Re: [PATCH] WAN: flush tx_queue in hdlc_ppp to prevent panic on rmmod hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4BD0C5DD.4040304@ruggedcom.com>
Date:	Thu, 22 Apr 2010 17:55:41 -0400
From:	Michael Barkowski <michaelbarkowski@...gedcom.com>
To:	David Miller <davem@...emloft.net>
CC:	"khc@...waw.pl" <khc@...waw.pl>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] WAN: flush tx_queue in hdlc_ppp to prevent panic on rmmod
 hw_driver.

David Miller wrote:
> From: Michael Barkowski <michaelbarkowski@...gedcom.com>
> Date: Thu, 22 Apr 2010 15:17:13 -0400
> 
>> Krzysztof Halasa wrote:
>>> tx_queue is used as a temporary queue when not allowed to queue skb
>>> directly to the hw device driver (which may sleep). Most paths flush
>>> it before returning, but ppp_start() currently cannot. Make sure we
>>> don't leave skbs pointing to a non-existent device.
>>>
>>> Thanks to Michael Barkowski for reporting this problem.
>> Great - thanks.  Will this be going into -stable?
> 
> When I think it's cooked long enough in Linus's tree and
> I submit it there.  That can take a few weeks.
> 

Super.  By the way, should have mentioned - tested and works for me

-- 
Michael Barkowski
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html