netdev - Re: [patch] wimax: wimax_msg_alloc() returns ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1271973596.2867.3.camel@localhost.localdomain>
Date:	Thu, 22 Apr 2010 14:59:56 -0700
From:	Inaky Perez-Gonzalez <inaky@...ux.intel.com>
To:	Dan Carpenter <error27@...il.com>
Cc:	netdev@...r.kernel.org,
	André Goddard Rosa <andre.goddard@...il.com>,
	kernel-janitors@...r.kernel.org, wimax@...uxwimax.org,
	linux-wimax@...el.com
Subject: Re: [patch] wimax: wimax_msg_alloc() returns ERR_PTR not null

On Thu, 2010-04-22 at 11:46 +0200, Dan Carpenter wrote: 
> wimax_msg_alloc() returns an ERR_PTR and not null.  I changed it to test
> for ERR_PTR instead of null.  I also added a check in front of the
> kfree() because kfree() can handle null but not ERR_PTR.
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>

Good catch thank you!

Will merge ASAP in preparation for the next push


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html