lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <p2i412e6f7f1004212330y6f3e2a92oa295e528afde3cd4@mail.gmail.com> Date: Thu, 22 Apr 2010 14:30:33 +0800 From: Changli Gao <xiaosuo@...il.com> To: Stephen Hemminger <shemminger@...tta.com> Cc: "David S. Miller" <davem@...emloft.net>, jamal <hadi@...erus.ca>, Tom Herbert <therbert@...gle.com>, Eric Dumazet <eric.dumazet@...il.com>, netdev@...r.kernel.org Subject: Re: [PATCH v4] net: batch skb dequeueing from softnet input_pkt_queue On Thu, Apr 22, 2010 at 2:18 PM, Stephen Hemminger <shemminger@...tta.com> wrote: > On Thu, 22 Apr 2010 13:51:53 +0800 > Changli Gao <xiaosuo@...il.com> wrote: > >> + struct sk_buff *input_pkt_queue_head; >> + struct sk_buff **input_pkt_queue_tailp; >> + unsigned int input_pkt_queue_len; >> + unsigned int process_queue_len; > > Why is opencoding a skb queue a step forward? > Just keep using sk_queue routines, just not the locked variants. > I want to keep the critical section of rps_lock() as small as possible to reduce the potential lock contention, when RPS is used. -- Regards, Changli Gao(xiaosuo@...il.com) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists