lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20100422.002623.00784210.davem@davemloft.net> Date: Thu, 22 Apr 2010 00:26:23 -0700 (PDT) From: David Miller <davem@...emloft.net> To: eric.dumazet@...il.com Cc: netdev@...r.kernel.org Subject: Re: [PATCH net-next-2.6] net: Introduce skb_orphan_try() From: Eric Dumazet <eric.dumazet@...il.com> Date: Thu, 22 Apr 2010 09:24:05 +0200 > Hmm... are you sure we want to call destructor for each skb ? > > Should'nt we do it before initial skb is split ? Good idea, therefore you mean something like this? diff --git a/net/core/dev.c b/net/core/dev.c index 3ba774b..f3c3885 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1865,6 +1865,7 @@ static int dev_gso_segment(struct sk_buff *skb) int features = dev->features & ~(illegal_highdma(dev, skb) ? NETIF_F_SG : 0); + skb_orphan_try(skb); segs = skb_gso_segment(skb, features); /* Verifying header integrity only. */ -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists