lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <4BD040FE.3000809@trash.net> Date: Thu, 22 Apr 2010 14:28:46 +0200 From: Patrick McHardy <kaber@...sh.net> To: Paul LeoNerd Evans <leonerd@...nerd.org.uk> CC: netdev@...r.kernel.org Subject: Re: [PATCH] Socket filter ancilliary data access for skb->dev->type Paul LeoNerd Evans wrote: > Add an SKF_AD_HATYPE field to the packet ancilliary data area, giving > access to skb->dev->type, as reported in the sll_hatype field. > > When capturing packets on a PF_PACKET/SOCK_RAW socket bound to all > interfaces, there doesn't appear to be a way for the filter program to > actually find out the underlying hardware type the packet was captured > on. This patch adds such ability. > > + case SKF_AD_HATYPE: > + A = skb->dev->type; > + continue; I think we should be adding a check whether skb->dev is non-NULL here since filters can also be attached to netlink sockets. The same applies to SKF_AD_IFINDEX. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists