lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20100422123347.GA5265@vigoh> Date: Thu, 22 Apr 2010 09:33:47 -0300 From: "Gustavo F. Padovan" <gustavo@...ovan.org> To: Dan Carpenter <error27@...il.com> Cc: Marcel Holtmann <marcel@...tmann.org>, "David S. Miller" <davem@...emloft.net>, Andrei Emeltchenko <andrei.emeltchenko@...ia.com>, linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [patch] bluetooth: handle l2cap_create_connless_pdu() errors Hi Dan, * Dan Carpenter <error27@...il.com> [2010-04-22 11:52:01 +0200]: > l2cap_create_connless_pdu() can sometimes return ERR_PTR(-ENOMEM) or > ERR_PTR(-EFAULT). > > Signed-off-by: Dan Carpenter <error27@...il.com> > > diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c > index 99d68c3..9753b69 100644 > --- a/net/bluetooth/l2cap.c > +++ b/net/bluetooth/l2cap.c > @@ -1626,7 +1626,10 @@ static int l2cap_sock_sendmsg(struct kiocb *iocb, struct socket *sock, struct ms > /* Connectionless channel */ > if (sk->sk_type == SOCK_DGRAM) { > skb = l2cap_create_connless_pdu(sk, msg, len); > - err = l2cap_do_send(sk, skb); > + if (IS_ERR(skb)) > + err = PTR_ERR(skb); > + else > + err = l2cap_do_send(sk, skb); > goto done; > } Your fix looks ok, but we have changed l2cap_do_send() to void, so you have to modify your patch. That change is not in the bluetooth-testingtree yet, so remote add my git tree and use the branch ertm. git://git.profusion.mobi/users/padovan/bluetooth-testing.git Regards, -- Gustavo F. Padovan http://padovan.org -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists