netdev - Re: [PATCH (v4)] bridge: update sysfs link names if port device names have changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100506124038.1b9849c7@nehalam>
Date:	Thu, 6 May 2010 12:40:38 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Simon Arlott <simon@...e.lp0.eu>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH (v4)] bridge: update sysfs link names if port device
 names have changed

On Thu, 06 May 2010 20:37:11 +0100
Simon Arlott <simon@...e.lp0.eu> wrote:

> Links for each port are created in sysfs using the device
> name, but this could be changed after being added to the
> bridge.
> 
> As well as being unable to remove interfaces after this
> occurs (because userspace tools don't recognise the new
> name, and the kernel won't recognise the old name), adding
> another interface with the old name to the bridge will
> cause an error trying to create the sysfs link.
> 
> This fixes the problem by listening for NETDEV_CHANGENAME
> notifications and renaming the link.
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=12743
> 
> Signed-off-by: Simon Arlott <simon@...e.lp0.eu>

Looks good
Acked-by: Stephen Hemminger <shemminger@...tta.com>


-- 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html