netdev - Re: [PATCH -next] bridge: fix build for CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100517.223237.55871633.davem@davemloft.net>
Date:	Mon, 17 May 2010 22:32:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	randy.dunlap@...cle.com
Cc:	shemminger@...tta.com, sfr@...b.auug.org.au,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH -next] bridge: fix build for CONFIG_SYSFS disabled

From: Randy Dunlap <randy.dunlap@...cle.com>
Date: Mon, 17 May 2010 11:01:12 -0700

> On 05/17/10 10:56, Stephen Hemminger wrote:
>> On Mon, 17 May 2010 09:17:56 -0700
>> Randy Dunlap <randy.dunlap@...cle.com> wrote:
>> 
>>> From: Randy Dunlap <randy.dunlap@...cle.com>
>>>
>>> Fix build when CONFIG_SYSFS is not enabled:
>>>
>>> net/bridge/br_if.c:136: error: 'struct net_bridge_port' has no member named 'sysfs_name'
>>>
>>> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
...
>> I don't like peppering code with #ifdef like this.
> 
> Thanks.  I didn't like it either.
> 
>> Turns out that in this place sysfs_name is always the same
>> as the device name so instead:

Stephen, please give me a formal submission of this fix with proper
signoff and credit to Randy.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html