netdev - Re: [PATCH v2] Fix SJA1000 command register writes on SMP systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100517.223415.184853371.davem@davemloft.net>
Date:	Mon, 17 May 2010 22:34:15 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	socketcan@...tkopp.net
Cc:	wg@...ndegger.com, netdev@...r.kernel.org,
	socketcan-core@...ts.berlios.de
Subject: Re: [PATCH v2] Fix SJA1000 command register writes on SMP systems

From: Oliver Hartkopp <socketcan@...tkopp.net>
Date: Mon, 17 May 2010 22:17:40 +0200

> diff --git a/drivers/net/can/sja1000/sja1000.c b/drivers/net/can/sja1000/sja1000.c
> index 145b1a7..2760085 100644
> --- a/drivers/net/can/sja1000/sja1000.c
> +++ b/drivers/net/can/sja1000/sja1000.c
> @@ -84,6 +84,27 @@ static struct can_bittiming_const sja1000_bittiming_const = {
>  	.brp_inc = 1,
>  };
>  +static void sja1000_write_cmdreg(struct sja1000_priv *priv, u8 val)
> +{
> +	/* the command register needs some locking on SMP systems */
> +
> +#ifdef CONFIG_SMP

Something is adding spurious leading spaces to lines in your patch.

Also, please don't SMP conditionalize this code.  It makes it such that
lock debugging et al. can't be used to check this code on uniprocessor.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html