netdev - Re: [PATCH]: niu: fix uninitialized variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100527.162342.183041034.davem@davemloft.net>
Date:	Thu, 27 May 2010 16:23:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	prarit@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH]: niu: fix uninitialized variable warning

From: Prarit Bhargava <prarit@...hat.com>
Date: Thu, 27 May 2010 14:35:03 -0400

> Fixes warning:
> 
> drivers/net/niu.c: In function ‘niu_process_rx_pkt’:
> drivers/net/niu.c:3457: error: ‘link’ may be used uninitialized in this function
> 
> Signed-off-by: Prarit Bhargava <prarit@...hat.com>

These blind uninitialized_var() annotations are almost always the wrong
thing to do.  And that is the case here.

The code that looks up the page here can return NULL if there is some
error and the page hashes aren't setup properly, and then the callers
go and blindly assume that 'page' is non-NULL without any error
checking.

Applying this patch does more harm than good because it hides this
issue.  So I'm definitely not applying this patch.