netdev - Re: [PATCH]: bnx2: Fix uninitialized variable warning in bnx2_disable_forced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 27 May 2010 16:26:33 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	prarit@...hat.com
Cc:	netdev@...r.kernel.org, mchan@...adcom.com
Subject: Re: [PATCH]: bnx2: Fix uninitialized variable warning in
 bnx2_disable_forced_2g5()

From: Prarit Bhargava <prarit@...hat.com>
Date: Thu, 27 May 2010 18:13:01 -0400

> Fix warning:
> 
> drivers/net/bnx2.c: In function 'bnx2_disable_forced_2g5':
> drivers/net/bnx2.c:1489: warning: 'bmcr' may be used uninitialized in this function
> 
> Signed-off-by: Prarit Bhargava <prarit@...hat.com>

This is another bad patch, you're hiding a bug by making this warning
go away.

If bnx2_read_phy() in fact does not initialize "bmcr" we might
want to do something about that instead of just blindly using
whatever garbage is in that local variable.

Please stop making these patches without applying at least some
intelligence to the analysis of why these warnings are being
printed at all.

None of these cases you're posting patches for are situations where
the compiler simply can't see the control flow properly, they are real
issues.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html