netdev - Re: [PATCH] bnx2: Fix IRQ failures during kdump.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C27F8246C663564A84BB7AB3439772421B78147574@IRVEXCHCCR01.corp.ad.broadcom.com>
Date:	Sun, 30 May 2010 09:12:15 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"'Andi Kleen'" <andi@...stfloor.org>
cc:	"'davem@...emloft.net'" <davem@...emloft.net>,
	"'netdev@...r.kernel.org'" <netdev@...r.kernel.org>,
	"'linux-pci@...r.kernel.org'" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH] bnx2: Fix IRQ failures during kdump.

Andi Kleen wrote:

> "Michael Chan" <mchan@...adcom.com> writes:
> 
> > When switching from the crashed kernel to the kdump kernel without
> going
> > through PCI reset, IRQs may not work if a different IRQ mode is used
> on
> 
> PCIe with AER actually does support per link root port reset
> (e.g. used for AER)

Do you mean the slot_reset function in the pci_error_handlers?  This
needs to be called in the context of the crashed kernel, right?

> 
> I've been wondering for some time if kexec should not simply
> use that to reset all the devices, instead of addings hacks
> around this to all drivers.
> 
> That would fix your problems too, right?

If it is called in the context of the crashed kernel, it won't work.
We would reset it and put in back into the same IRQ mode.

> 
> The question is just if AER is widely enough supported for this.
> 

Some newer PCIe devices support Function Level Reset, and that would
be ideal.  But most existing devices including bnx2 devices don't have
this feature.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html