netdev - Re: [PATCH] bnx2: Fix IRQ failures during kdump.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C27F8246C663564A84BB7AB3439772421B78147575@IRVEXCHCCR01.corp.ad.broadcom.com>
Date:	Sun, 30 May 2010 09:32:32 -0700
From:	"Michael Chan" <mchan@...adcom.com>
To:	"'David Miller'" <davem@...emloft.net>,
	"'matthew@....cx'" <matthew@....cx>
cc:	"'grundler@...isc-linux.org'" <grundler@...isc-linux.org>,
	"'netdev@...r.kernel.org'" <netdev@...r.kernel.org>,
	"'linux-pci@...r.kernel.org'" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH] bnx2: Fix IRQ failures during kdump.

David Miller wrote:

> From: Matthew Wilcox <matthew@....cx>
> Date: Sat, 29 May 2010 19:24:01 -0600
> 
> > We should probably set the interrupt type back to pin-based before
> the
> > kexec kernel starts, right?  Or do we expect drivers to handle being
> > initialised with the device still set to MSI mode?
> 
> The expectation is that the device comes up in INTX mode, which is the
> default after a PCI reset.

We need to be very careful because the device may still be active as I
said earlier.  Turning INTX on may lead to an IRQ storm that nobody will
handle.  Some older devices don't have the INTX enable bit, and INTX will
automatically be enabled when MSI is disabled.

> 
> Basically all of these issues tend to be about the fact that unlike on
> a normal boot, after a kexec an intermediate PCI reset has not occured.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html