netdev - Re: [PATCH 1/2] Export firmware assigned labels of network devices to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1275314876.21246.29.camel@concordia>
Date:	Tue, 01 Jun 2010 00:07:56 +1000
From:	Michael Ellerman <michael@...erman.id.au>
To:	"K, Narendra" <Narendra_K@...l.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-hotplug@...r.kernel.org" <linux-hotplug@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"Domsch, Matt" <Matt_Domsch@...l.com>,
	"Hargrave, Jordan" <Jordan_Hargrave@...l.com>,
	"Rose, Charles" <Charles_Rose@...l.com>,
	"Nijhawan, Vijay" <Vijay_Nijhawan@...l.com>
Subject: Re: [PATCH 1/2] Export firmware assigned labels of network devices
 to sysfs

On Fri, 2010-05-28 at 06:55 -0500, K, Narendra wrote:
> Hello,
> 
> This patch is in continuation of an earlier discussion -
> 
> http://marc.info/?l=linux-netdev&m=126712978908314&w=3
> 
> The patch has the following review suggestions from the community incorporated -
> 
> 1. The name of the attribute has been changed from "smbiosname" to "label" to hide
> the implementation details.
> 2. The implementation has been moved to a new file drivers/pci/pci-label.c

You've changed the name, which is good, but the implementation is still
100% dependant on ACPI or DMI AFAICS.

So it seems to me until it's supported on another platform it may as
well go in pci-acpi.c, or at least only be compiled if (ACPI || DMI).
Otherwise it's just dead code.

cheers



Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)