lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 3 Jun 2010 23:42:57 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Junchang Wang <junchangwang@...il.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [Patch 1/2]r8169: remove rtl_rw_cpluscmd

Junchang Wang <junchangwang@...il.com> :
> Some clean up work. Please correct me if any of this is wrong.
> 
> Writting "cmd" back without modification is redundant.
> Secondly, because rtl_rw_cpluscmd is just encapsulation of
> RTL_R16, remove rtl_rw_cpluscmd.

I'll figure that there may be some value in the patch if you
test the change on revision X, Y and Z.

Some cosmetic isolated in a sequence of changes can be fine too.

Otherwise I consider such cleanups as a (useless and) conceivably
harmful distraction.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists