netdev - Re: [Patch 1/2]r8169: remove rtl_rw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTinU-eRWzHV2HD7rGdC5sECkoEinDmZHZw9_llez@mail.gmail.com>
Date:	Fri, 4 Jun 2010 09:37:14 +0800
From:	Junchang Wang <junchangwang@...il.com>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [Patch 1/2]r8169: remove rtl_rw_cpluscmd

> I'll figure that there may be some value in the patch if you
> test the change on revision X, Y and Z.

Frankly, I just tested the patch on my NIC. It works fine.

>
> Some cosmetic isolated in a sequence of changes can be fine too.
>
> Otherwise I consider such cleanups as a (useless and) conceivably
> harmful distraction.

As I said, those points really confused me while I was going over the
driver. I searched google and mailing list archive but failed to get
any traces. It seems they exist for a long time without any touch
(care). So I decided to post the patches to see whether they are
harmful or not.

OK. I'll bypass legacy hardware-related codes since they are really
very tricky. :)

Thanks Francois.

-- 
--Junchang
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html