netdev - RE: [net-next-2.6 PATCH] ixgbe: Use netdev_<level>, dev_<level>, pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <EA929A9653AAE14F841771FB1DE5A1365FF4077103@rrsmsx501.amr.corp.intel.com>
Date:	Fri, 4 Jun 2010 17:44:04 -0600
From:	"Tantilov, Emil S" <emil.s.tantilov@...el.com>
To:	Joe Perches <joe@...ches.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>
Subject: RE: [net-next-2.6 PATCH] ixgbe: Use netdev_<level>, dev_<level>,
 pr_<level>

Joe Perches wrote:
> On Thu, 2010-06-03 at 19:53 -0700, Jeff Kirsher wrote:
>> From: Emil Tantilov <emil.s.tantilov@...el.com>
> 
> Hi Emil.
> 
>> This patch is alternative to a previous patch submitted by Joe
>> Perches. 
> 
> Why eliminate all the adapter->msg_enable tests?
> 
> There are many changes like this. For instance:
> 
>>  	if (link_up && (link_speed == IXGBE_LINK_SPEED_1GB_FULL))
>> -		netif_info(adapter, hw, adapter->netdev, "Smartspeed has"
>> -			" downgraded the link speed from the maximum"
>> -			" advertised\n");
>> +		e_info("Smartspeed has downgraded the link speed from "
>> +		       "the maximum advertised\n");
> 
> This was only printed when NETIF_MSG_HW was set,
> now it's always printed.

That's a good question. I'll fix it up and post a follow-up patch, or if Dave wants to reverse it - either way it's fine with me.

Thanks for reviewing.
Emil