netdev - Re: [net-next-2.6 PATCH] ixgbe: Use netdev_<level>, dev_<level>, pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1275621605.1703.38.camel@Joe-Laptop.home>
Date:	Thu, 03 Jun 2010 20:20:05 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, gospo@...hat.com,
	Emil Tantilov <emil.s.tantilov@...el.com>
Subject: Re: [net-next-2.6 PATCH] ixgbe: Use netdev_<level>, dev_<level>,
 pr_<level>

On Thu, 2010-06-03 at 19:53 -0700, Jeff Kirsher wrote:
> From: Emil Tantilov <emil.s.tantilov@...el.com>

Hi Emil.

> This patch is alternative to a previous patch submitted by Joe Perches.

Why eliminate all the adapter->msg_enable tests?

There are many changes like this. For instance:

>  	if (link_up && (link_speed == IXGBE_LINK_SPEED_1GB_FULL))
> -		netif_info(adapter, hw, adapter->netdev, "Smartspeed has"
> -			" downgraded the link speed from the maximum"
> -			" advertised\n");
> +		e_info("Smartspeed has downgraded the link speed from "
> +		       "the maximum advertised\n");

This was only printed when NETIF_MSG_HW was set,
now it's always printed.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html