netdev - Re: [PATCH 1/2] pktgen: increasing transmission granularity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100609.135040.193710199.davem@davemloft.net>
Date:	Wed, 09 Jun 2010 13:50:40 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	daniel.turull@...il.com
Cc:	netdev@...r.kernel.org, robert@...julf.net, jens.laas@....uu.se
Subject: Re: [PATCH 1/2] pktgen: increasing transmission granularity

From: Daniel Turull <daniel.turull@...il.com>
Date: Wed, 02 Jun 2010 13:49:07 +0200

> This patch increases the granularity of the rate generated by pktgen.
> The previous version of pktgen uses micro seconds (udelay) resolution when it 
> was delayed causing gaps in the rates. It is changed to nanosecond (ndelay).
> Now any rate is possible.
> 
> Also it allows to set, the desired rate in Mb/s or packets per second.
> 
> The documentation has been updated.
> 
> Signed-off-by: Daniel Turull <daniel.turull@...il.com>

I like this, however although most of this is adding a new
feature, this part:

> @@ -2170,7 +2204,7 @@ static void spin(struct pktgen_dev *pkt_dev, ktime_t spin_until)
>  	end_time = ktime_now();
>  
>  	pkt_dev->idle_acc += ktime_to_ns(ktime_sub(end_time, start_time));
> -	pkt_dev->next_tx = ktime_add_ns(end_time, pkt_dev->delay);
> +	pkt_dev->next_tx = ktime_add_ns(spin_until, pkt_dev->delay);
>  }
>  
>  static inline void set_pkt_overhead(struct pktgen_dev *pkt_dev)

Is a bug fix, since it makes sure the inter-packet interval is
accurate.

Can you please submit this part seperately, so I can apply it to
net-2.6   Then you can submit the nanosecond feature parts
relative to this, which I'll apply to net-next-2.6

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html