netdev - Re: [PATCH v3] netfilter: Xtables: idletimer target implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.01.1006092304270.16916@obet.zrqbmnf.qr>
Date:	Wed, 9 Jun 2010 23:05:28 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	Luciano Coelho <luciano.coelho@...ia.com>
cc:	ext Patrick McHardy <kaber@...sh.net>,
	"netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Timo Teras <timo.teras@....fi>
Subject: Re: [PATCH v3] netfilter: Xtables: idletimer target implementation

On Wednesday 2010-06-09 20:42, Luciano Coelho wrote:
>
>> I'll move the sysfs file creation to outside that function so I can keep
>> the lock until after the timer is added to the list.  Thanks for
>> clarifying!
>
>Hmmm... after struggling with this for a while, I think it's not really
>possible to simply create the sysfs file outside of the lock, because if
>the sysfs creation fails, we will again risk a race condition.

Well if sysfs_add can return an error code when a file already
exists (instead of adding it again), it's much easier. Try checking.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html