netdev - Re: [PATCH net-next-2.6] syncookies: check decoded options against sysctl settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100615.180947.241927235.davem@davemloft.net>
Date:	Tue, 15 Jun 2010 18:09:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fw@...len.de
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] syncookies: check decoded options against
 sysctl settings

From: Florian Westphal <fw@...len.de>
Date: Sun, 13 Jun 2010 23:34:35 +0200

> -	if (tcp_opt->sack_ok)
> -		tcp_sack_reset(tcp_opt);
> +	if (tcp_opt->sack_ok && !sysctl_tcp_sack)
> +		return false;
>  

If you remove the tcp_sack_reset() call here, who is going to
do it?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html