netdev - Re: [PATCH net-next-2.6] ipv6: syncookies: do not skip ->iif initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100615.181042.98892458.davem@davemloft.net>
Date:	Tue, 15 Jun 2010 18:10:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fw@...len.de
Cc:	netdev@...r.kernel.org, ggriffin.kernel@...il.com
Subject: Re: [PATCH net-next-2.6] ipv6: syncookies: do not skip ->iif
 initialization

From: Florian Westphal <fw@...len.de>
Date: Sun, 13 Jun 2010 23:29:39 +0200

> When syncookies are in effect, req->iif is left uninitialized.
> In case of e.g. link-local addresses the route lookup then fails
> and no syn-ack is sent.
> 
> Rearrange things so ->iif is also initialized in the syncookie case.
> 
> want_cookie can only be true when the isn was zero, thus move the want_cookie
> check into the "!isn" branch.
> 
> Cc: Glenn Griffin <ggriffin.kernel@...il.com>
> Signed-off-by: Florian Westphal <fw@...len.de>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html