netdev - Re: [PATCH net-next-2.6] netfilter: allow nf_tproxy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C2379D9.2080608@trash.net>
Date:	Thu, 24 Jun 2010 17:29:29 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	David Miller <davem@...emloft.net>
CC:	fw@...len.de, jpirko@...hat.com, netdev@...r.kernel.org,
	Balazs Scheidler <bazsi@...abit.hu>,
	KOVACS Krisztian <hidden@....bme.hu>
Subject: Re: [PATCH net-next-2.6] netfilter: allow nf_tproxy_core module to
 be removed

David Miller wrote:
> From: Florian Westphal <fw@...len.de>
> Date: Wed, 23 Jun 2010 20:46:11 +0200
>
>   
>> tproxy assigns skb->destructor, what prevents module unload while such skbs may
>> still be around?
>>     
>
> The only reference to nf_tproxy_core.ko is for the symbol, "nf_tproxy_assign_sock".
> xt_TPROXY.c, which references this symbol, thus creates a symbol dependency on this
> module, so xt_TPROXY.o needs to unload before nf_tproxy_core.ko can unload, and
> xt_TPROXY.o has it's own manner for handling module references properly.
>   

I don't see anything waiting for skbs in flight using the tproxy
destructor in either xt_TPROXY or nf_tproxy_core though, so I think
Florian is correct.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html