netdev - Re: [PATCH net-next-2.6 1/2] 3c59x: Specify window explicitly for access to windowed registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100628.232055.15240656.davem@davemloft.net>
Date:	Mon, 28 Jun 2010 23:20:55 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ben@...adent.org.uk
Cc:	netdev@...r.kernel.org, chase.douglas@...onical.com,
	nordmark@...h.kth.se
Subject: Re: [PATCH net-next-2.6 1/2] 3c59x: Specify window explicitly for
 access to windowed registers

From: Ben Hutchings <ben@...adent.org.uk>
Date: Thu, 24 Jun 2010 00:54:31 +0100

> Currently much of the code assumes that a specific window has been
> selected, while a few functions save and restore the window.  This
> makes it impossible to introduce fine-grained locking.
> 
> Make those assumptions explicit by introducing wrapper functions
> to set the window and read/write a register.  Use these everywhere
> except vortex_interrupt(), vortex_start_xmit() and vortex_rx().
> These set the window just once, or not at all in the case of
> vortex_rx() as it should always be called from vortex_interrupt().
> 
> Cache the current window in struct vortex_private to avoid
> unnecessary hardware writes.
> 
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> Tested-by: Arne Nordmark <nordmark@...h.kth.se> [against 2.6.32]

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html