netdev - Re: [PATCH -next] myri10ge: clear NETIF_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100630132622.499f41a0@dhcp-lab-109.englab.brq.redhat.com>
Date:	Wed, 30 Jun 2010 13:26:22 +0200
From:	Stanislaw Gruszka <sgruszka@...hat.com>
To:	Andrew Gallatin <gallatin@...i.com>
Cc:	netdev@...r.kernel.org, Amerigo Wang <amwang@...hat.com>,
	Brice Goglin <brice@...i.com>
Subject: Re: [PATCH -next] myri10ge: clear NETIF_F_LRO bit directly

On Tue, 29 Jun 2010 11:44:14 -0400
Andrew Gallatin <gallatin@...i.com> wrote:

> Stanislaw Gruszka wrote:
> > Do not use ethtool_op_set_flags() to clear one bit in ->features.
> > Inform user about disabling LRO.
> 
> Thanks.. That simplifies things nicely.  But was
> direct manipulation of netdev->features ever discouraged,
> or has my use of ethtool_op_{get,set}_flags() to manipulate
> the features always been complete overkill?

It was a bit overkill. Manipulate netdev->features is fine,
many drivers do it.

> > Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com>
> 
> Acked-by: Andrew J. Gallatin <gallatin@...i.com>

Thanks. FYI: Ben Hutchings posted other patch spread over
all drivers: http://patchwork.ozlabs.org/patch/57286/
we most likely will use it to put this myri10ge bits in.

Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html