netdev - Re: [RFC] gre: propagate ipv6 transport class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100708.213645.183036637.davem@davemloft.net>
Date:	Thu, 08 Jul 2010 21:36:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	yoshfuji@...ux-ipv6.org, herbert@...dor.apana.org.au,
	netdev@...r.kernel.org
Subject: Re: [RFC] gre: propagate ipv6 transport class

From: Stephen Hemminger <shemminger@...tta.com>
Date: Tue, 6 Jul 2010 10:58:21 -0700

> This patch makes IPV6 over IPv4 GRE tunnel propagate the transport
> class field from the underlying IPV6 header to the IPV4 Type Of Service
> field. Without the patch, all IPV6 packets in tunnel look the same to QoS.
> 
> This assumes that IPV6 transport class is exactly the same
> as IPv4 TOS. Not sure if that is always the case?  Maybe need
> to mask off some bits.
> 
> The mask and shift to get tclass is copied from ipv6/datagram.c
> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>

Looks good, but we should use ipv6_get_dsfield() just like
ipgre_ecn_encapsulate() does.

Note that this also influences the route since this 'tos' feeds
into the flowi lookup key.  We should make sure that this is OK
too.

Anyways, I've committed the following to net-next-2.6, thanks!

--------------------
gre: propagate ipv6 transport class

This patch makes IPV6 over IPv4 GRE tunnel propagate the transport
class field from the underlying IPV6 header to the IPV4 Type Of Service
field. Without the patch, all IPV6 packets in tunnel look the same to QoS.

This assumes that IPV6 transport class is exactly the same
as IPv4 TOS. Not sure if that is always the case?  Maybe need
to mask off some bits.

The mask and shift to get tclass is copied from ipv6/datagram.c

Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
Signed-off-by: David S. Miller <davem@...emloft.net>
---
 net/ipv4/ip_gre.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c
index 749e548..945b20a 100644
--- a/net/ipv4/ip_gre.c
+++ b/net/ipv4/ip_gre.c
@@ -731,6 +731,8 @@ static netdev_tx_t ipgre_tunnel_xmit(struct sk_buff *skb, struct net_device *dev
 		tos = 0;
 		if (skb->protocol == htons(ETH_P_IP))
 			tos = old_iph->tos;
+		else if (skb->protocol == htons(ETH_P_IPV6))
+			tos = ipv6_get_dsfield((struct ipv6hdr *)old_iph);
 	}
 
 	{
-- 
1.7.1.1



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html