netdev - Re: [PATCH linux-2.6.35-rc3] ks8842 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100708.214101.39178389.davem@davemloft.net>
Date:	Thu, 08 Jul 2010 21:41:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	David.Choi@...rel.Com
Cc:	horms@...ge.net.au, netdev@...r.kernel.org, Charles.Li@...rel.Com
Subject: Re: [PATCH linux-2.6.35-rc3] ks8842 driver

From: "Choi, David" <David.Choi@...rel.Com>
Date: Thu, 8 Jul 2010 12:01:51 -0700

> The original ks8842 driver is designed to work on the customized bus
> interface based on an FPGA. This patch is intended to address the more
> commonly used generic bus interface available on the majority of SoC in
> the market.
> 
> It is unlikely that for a system to use both FPGA based and generic bus
> interface for ks8842, I am quite certain that those 2 devices are used
> mutual exclusively.

Like Simon, I'm not to thrilled with this approach.

Any flag bit test you'd need to add to the driver to handle both cases
will have zero performance impact since the cost of the MMIO accesses
will dominate such tests entirely.

Add a boolean flag bit to the driver software state, set it based upon
some platform_device private setting, and test it in these paths to
device what to do.

As a bonus, anyone who enables this driver at all in their build will
test the compilation of both code paths.  And to me, that extra
compilation testing trumps whatever arguments you may make for not
making this support dynamic.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html