netdev - Re: [PATCH] ks8842: Do the TX timeout work in workqueue context.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 08 Jul 2010 21:43:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	richard.rojfors@...agicore.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ks8842: Do the TX timeout work in workqueue context.

From: Richard Röjfors <richard.rojfors@...agicore.com>
Date: Tue, 06 Jul 2010 17:20:25 +0200

> Currently all code that needs to be run at TX timeout is done in the
> calling context, where bottom halves are disabled. Some of the code
> blocks, so it needs to be done in a different context. This patch
> adds in a work struct which is scheduled at TX timeout. Then the
> timeout code is executed within work queue context.
> 
> Signed-off-by: Richard Röjfors <richard.rojfors@...agicore.com>

Your patch is corrupted by your email client, and it does more than
you say it does in this commit message:

>  static inline void ks8842_select_bank(struct ks8842_adapter *adapter,
> u16 bank)
> @@ -197,7 +199,6 @@ static void ks8842_reset(struct ks8842_adapter
> *adapter)

Your email client is wrapping long lines in the patch, corrupting it
and making it unusable.  Please fix your email client to not molest
the patch in any way.

>  	msleep(10);
>  	iowrite16(0, adapter->hw_addr + REG_GRR);
>  	*/
> -	iowrite16(32, adapter->hw_addr + REG_SELECT_BANK);
>  	iowrite32(0x1, adapter->hw_addr + REG_TIMB_RST);
>  	msleep(20);
>  }

Your commit message fails to describe what this REG_SELECT_BANK write
removal is needed for.  It must be accounted for in your log message
otherwise other developers won't understand why this line gets
removed in your change.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html