netdev - Re: [PATCH] cxgb4vf: remove obsolete DECLARE_PCI_UNMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100708.230939.102558536.davem@davemloft.net>
Date:	Thu, 08 Jul 2010 23:09:39 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fujita.tomonori@....ntt.co.jp
Cc:	leedom@...lsio.com, netdev@...r.kernel.org
Subject: Re: [PATCH] cxgb4vf: remove obsolete DECLARE_PCI_UNMAP_ADDR usage

From: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Date: Thu, 08 Jul 2010 19:01:26 +0900

> On Thu, 8 Jul 2010 18:52:37 +0900
> FUJITA Tomonori <fujita.tomonori@....ntt.co.jp> wrote:
> 
>> We could use DEFINE_DMA_UNMAP_ADDR instead but using
>> CONFIG_NEED_DMA_MAP_STATE is a simpler way to see if a platform does
>> real DMA unmapping.
>> 
>> Signed-off-by: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
>> ---
>>  drivers/net/cxgb4vf/sge.c |   14 +++++---------
>>  1 files changed, 5 insertions(+), 9 deletions(-)
> 
> btw, I'm not sure that seeing if a platform does real DMA unmapping in
> a driver is a good thing. But I suppose that we need to accept it if
> this leads to big performance boost.
> 
> Both can be applied to net-next.

I think the value of these "optimizations" is rapidly decreasing to
zero.  And I believe I've told the authors of either this driver or
another one that they should just remove this stuff completely.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html