netdev - Re: [PATCH] cxgb4vf: remove obsolete DECLARE_PCI_UNMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100709151240M.fujita.tomonori@lab.ntt.co.jp>
Date:	Fri, 09 Jul 2010 15:12:40 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	davem@...emloft.net
Cc:	fujita.tomonori@....ntt.co.jp, leedom@...lsio.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] cxgb4vf: remove obsolete DECLARE_PCI_UNMAP_ADDR usage

On Thu, 08 Jul 2010 23:09:39 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> > btw, I'm not sure that seeing if a platform does real DMA unmapping in
> > a driver is a good thing. But I suppose that we need to accept it if
> > this leads to big performance boost.
> > 
> > Both can be applied to net-next.
> 
> I think the value of these "optimizations" is rapidly decreasing to
> zero.  And I believe I've told the authors of either this driver or
> another one that they should just remove this stuff completely.

I prefer to remove this stuff completely too.

If this trick improves the performance greatly, we could add this to
the DMA API (that's better than adding such ifdef hack to drivers).
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html