netdev - a couple questions about drivers/net/macv*.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1007101652030.7658@lynx>
Date:	Sat, 10 Jul 2010 19:44:59 -0400 (EDT)
From:	"Robert P. J. Day" <rpjday@...shcourse.ca>
To:	netdev@...r.kernel.org
Subject: a couple questions about drivers/net/macv*.c

  first (trivial) point, i notice that both macvlan.c and macvtap.c
are still both listed as EXPERIMENTAL -- is that still accurate?

  bigger issue in macvtap.c -- notice this declaration:

static unsigned int macvtap_major;

that seems like a violation of coding style since that variable is
used later on in:

        devt = MKDEV(MAJOR(macvtap_major), dev->ifindex);
 and

       err = alloc_chrdev_region(&macvtap_major, 0,
                                MACVTAP_NUM_DEVS, "macvtap");

where its type should simply be the typedef "dev_t" for transparency,
should it not?  hardcoding that variable as an unsigned int seems like
a bad idea.

rday

-- 

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

        Top-notch, inexpensive online Linux/OSS/kernel courses
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html