netdev - Re: [PATCH net-next-2.6] xfrm: cleanup of xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Jul 2010 08:21:03 +0300
From:	Rami Rosen <ramirose@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] xfrm: cleanup of xfrm_input.c. (resend)

 Hi,
  The patch removes unneeded inclusion of header files
 (linux/module.h, linux/netdevice.h, net/dst.h and net/ip.h) and adds inclusion
of linux/skbuff.h instead, in net/xfrm/xfrm_input.c.

 Regards,
 Rami Rosen

On Thu, Jul 15, 2010 at 3:59 AM, David Miller <davem@...emloft.net> wrote:
> From: Rami Rosen <ramirose@...il.com>
> Date: Wed, 14 Jul 2010 11:18:41 +0300
>
>> Hi,
>>  The patch removes unneeded inclusion of header files
>> (linux/module.h, linux/netdevice.h, net/dst.h and net/ip.h)
>>  in net/xfrm/xfrm_input.c
>>
>> Regards,
>> Rami Rosen
>>
>> Signed-off-by: Rami Rosen <ramirose@...il.com>
>
> If you do this, I also want to see you add includes for things like
> linux/skbuff.h since data structures such as "struct sk_buff"
> are used in this file.
>
> Otherwise, this is how we end up with obscure build failures on
> some configurations and not others, either now or in the future
> when a similar change is made to some header file.
>
>

View attachment "patch.txt" of type "text/plain" (464 bytes)