netdev - Re: [PATCH net-next-2.6] xfrm: cleanup of xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100714.224221.226759932.davem@davemloft.net>
Date:	Wed, 14 Jul 2010 22:42:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ramirose@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] xfrm: cleanup of xfrm_input.c. (resend)

From: Rami Rosen <ramirose@...il.com>
Date: Thu, 15 Jul 2010 08:21:03 +0300

>  Hi,
>   The patch removes unneeded inclusion of header files
>  (linux/module.h, linux/netdevice.h, net/dst.h and net/ip.h) and adds inclusion
> of linux/skbuff.h instead, in net/xfrm/xfrm_input.c.

Rami, please don't process my feedback like an automaton. :-/

I specifically mentioned linux/skbuff.h because that happened to be
the very first obvious header dependency I found in the xfrm_input.c
file.

There are almost certainly others, and I'd like for you to take the
time to skim over the file and figure out what those might be.

Also, when submitting a new version of a patch, do not hijack the
existing thread.  Instead, make a full fresh submission with a
plain fresh subject line, commit log message, signoff, and patch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html