netdev - Re: [PATCH] bonding: fix a buffer overflow in bonding_show_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100714.182505.115922952.davem@davemloft.net>
Date:	Wed, 14 Jul 2010 18:25:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nicolas.2p.debian@...e.fr
Cc:	bonding-devel@...ts.sourceforge.net, andy@...yhouse.net,
	fubar@...ibm.com, netdev@...r.kernel.org
Subject: Re: [PATCH] bonding: fix a buffer overflow in
 bonding_show_queue_id.

From: Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>
Date: Thu, 15 Jul 2010 00:24:37 +0200

> The test for buffer overflow ensures we have room for 6 more bytes.
> sprintf, called with %s:%d, slave->dev->name, slave->queue_id may yield
> far more than 6 bytes.
> 
> The correct test is res > (PAGE_SIZE - IFNAMSIZ - 6) .
> 
> Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@...e.fr>

Applied to net-next-2.6, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html